hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9372) Remove dead code in DataStorage.recoverTransitionRead
Date Thu, 05 Nov 2015 18:16:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992152#comment-14992152
] 

Hudson commented on HDFS-9372:
------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #8761 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8761/])
HDFS-9372. Remove dead code in DataStorage.recoverTransitionRead. (wheat9: rev efc73d7896e65a8a03d226ac21309257a7dc126c)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> Remove dead code in DataStorage.recoverTransitionRead
> -----------------------------------------------------
>
>                 Key: HDFS-9372
>                 URL: https://issues.apache.org/jira/browse/HDFS-9372
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9372-v0.patch, HDFS-9372-v1.patch
>
>
> {code:title=DataStorage.java}
>     if (this.initialized) {
>       LOG.info("DataNode version: " + HdfsServerConstants.DATANODE_LAYOUT_VERSION
>           + " and NameNode layout version: " + nsInfo.getLayoutVersion());
>       this.storageDirs = new ArrayList<StorageDirectory>(dataDirs.size());
>       // mark DN storage is initialized
>       this.initialized = true;
>     }
> {code}
> The first if should be {{!this.initialized}} I think?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message