hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9372) Typo in DataStorage.recoverTransitionRead
Date Wed, 04 Nov 2015 17:21:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989962#comment-14989962
] 

Haohui Mai commented on HDFS-9372:
----------------------------------

It looks like it's dead code. Let's simply remove it.

> Typo in DataStorage.recoverTransitionRead
> -----------------------------------------
>
>                 Key: HDFS-9372
>                 URL: https://issues.apache.org/jira/browse/HDFS-9372
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>         Attachments: HDFS-9372-v0.patch
>
>
> {code:title=DataStorage.java}
>     if (this.initialized) {
>       LOG.info("DataNode version: " + HdfsServerConstants.DATANODE_LAYOUT_VERSION
>           + " and NameNode layout version: " + nsInfo.getLayoutVersion());
>       this.storageDirs = new ArrayList<StorageDirectory>(dataDirs.size());
>       // mark DN storage is initialized
>       this.initialized = true;
>     }
> {code}
> The first if should be {{!this.initialized}} I think?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message