hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Clampffer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9368) Implement reads with implicit offset state in libhdfs++
Date Tue, 17 Nov 2015 23:02:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009787#comment-15009787
] 

James Clampffer commented on HDFS-9368:
---------------------------------------

Thanks for the feedback!

"Instead of returning -1, these function can return a Status object that encapsulates the
error code. Then the wrapper in the c binding side would become:<snip>"
Sounds good, my original goal was to match the posix signatures as well as possible but the
C API already comes close enough to that.  If there's a need for pure posix in the future
it will be trivial to make those shims.

"Let's use ios_base::seekdir"
I forgot about that, good catch.

"Might make sense to move the inline function to a .cc file."
Will do.

"unsigned long long get_file_length();
can be
uint64_t get_file_length() const;"
Sounds good to me.



> Implement reads with implicit offset state in libhdfs++
> -------------------------------------------------------
>
>                 Key: HDFS-9368
>                 URL: https://issues.apache.org/jira/browse/HDFS-9368
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>         Attachments: HDFS-9368.HDFS-8707.000.patch, HDFS-9368.HDFS-8707.001.patch
>
>
> Currently only positional reads are supported.  Implement a stateful read that keeps
track of offset into file.  Also expose it in the c bindings as hdfsRead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message