hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9351) checkNNStartup() need to be called when fsck calls FSNamesystem.getSnapshottableDirs()
Date Wed, 04 Nov 2015 05:00:30 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988887#comment-14988887
] 

Hudson commented on HDFS-9351:
------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #568 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/568/])
HDFS-9351. checkNNStartup() need to be called when fsck calls (yzhang: rev 194251c85250fcbe80a6ffee88b2cd4689334be3)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> checkNNStartup() need to be called when fsck calls FSNamesystem.getSnapshottableDirs()
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-9351
>                 URL: https://issues.apache.org/jira/browse/HDFS-9351
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: HDFS
>            Reporter: Yongjun Zhang
>            Assignee: Xiao Chen
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9351.patch
>
>
> I looked further at HDFS-9231 change I reviewed earlier, and realize I missed one thing.
> The patch changed
> {code}
>       if (snapshottableDirs != null) {
>         SnapshottableDirectoryStatus[] snapshotDirs = namenode.getRpcServer()
>             .getSnapshottableDirListing();
>         if (snapshotDirs != null) {
>           for (SnapshottableDirectoryStatus dir : snapshotDirs) {
>             snapshottableDirs.add(dir.getFullPath().toString());
>           }
>         }
>       }
> {code}
> to
> {code}
>       if (snapshottableDirs != null) {
>         snapshottableDirs = namenode.getNamesystem().getSnapshottableDirs();
>       }
> {code}
> In old code, namenode.getRpcServer().getSnapshottableDirListing() calls checkNNStartup(),
however, this is not done with the new code. This is a hole of the earlier HDFS-9231 patch.
> Create this jira to fix the hole. Suggest to revert this portion of the change, and add
code to do what we need at NamenodeFsck.
> Sorry for missing this in my earlier review of HDFS-9231.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message