hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Staffan Friberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9350) Avoid creating temprorary strings in Block.toString() and getBlockName()
Date Mon, 02 Nov 2015 18:47:28 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985738#comment-14985738
] 

Staffan Friberg commented on HDFS-9350:
---------------------------------------

It does, but the problem is that the call to Long.toString will actually allocate a new String
to be appended, and the call to getBlockname sometimes (unless correctly inlined will do the
same). So you don't get a single append chain with SB in this case.

> Avoid creating temprorary strings in Block.toString() and getBlockName()
> ------------------------------------------------------------------------
>
>                 Key: HDFS-9350
>                 URL: https://issues.apache.org/jira/browse/HDFS-9350
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: performance
>    Affects Versions: 2.7.1
>            Reporter: Staffan Friberg
>            Assignee: Staffan Friberg
>            Priority: Minor
>         Attachments: HDFS-9350.001.patch
>
>
> Minor change to use StringBuilders directly to avoid creating temporary strings of Long
and Block name when doing toString on a Block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message