hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-9339) Extend full test of KMS ACLs
Date Mon, 02 Nov 2015 21:36:27 GMT

     [ https://issues.apache.org/jira/browse/HDFS-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Daniel Templeton updated HDFS-9339:
    Attachment: HDFS-9339.002.patch

[~zhz], I tried making the tests use one big try-finally wrapper, and I just didn't like it
as much.  One thing the repeated try-finally blocks do is make it really obvious where the
subsections of the tests are.  Taking the blocks out leaves the tests rambling a bit.  Unless
its a big deal for you, I think the code is actually clearer with the try-finally blocks.

I did happen across a bug in HDFS-9295 that I fixed in the patch I just posted.

> Extend full test of KMS ACLs
> ----------------------------
>                 Key: HDFS-9339
>                 URL: https://issues.apache.org/jira/browse/HDFS-9339
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: HDFS
>    Affects Versions: 2.7.1
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>         Attachments: HDFS-9339.001.patch, HDFS-9339.002.patch
> HDFS-9295 adds an end-to-end test for KMS, but it is missing a dimension.  The tests
added in that JIRA hold the configuration constant and test that all operations succeed or
fail as expected.  More tests are needed that hold the operation constant and test that all
possible configurations cause the operations to succeed or fail as expected.  This JIRA is
to add those tests.

This message was sent by Atlassian JIRA

View raw message