hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt
Date Mon, 09 Nov 2015 17:46:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996985#comment-14996985
] 

Hadoop QA commented on HDFS-9328:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s {color} | {color:blue}
docker + precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red}
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 27s {color} | {color:red}
Patch generated 425 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 50s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.7.0 Server=1.7.0 Image:test-patch-base-hadoop-date2015-11-09 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12771114/HDFS-9328.HDFS-8707.001.patch
|
| JIRA Issue | HDFS-9328 |
| Optional Tests |  asflicense  site  |
| uname | Linux 2eaeb5354019 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
|
| git revision | HDFS-8707 / 3ce4230 |
| Default Java | 1.7.0_79 |
| Multi-JDK versions |  /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
|
| whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/13439/artifact/patchprocess/whitespace-eol.txt
|
| asflicense | https://builds.apache.org/job/PreCommit-HDFS-Build/13439/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
|
| Max memory used | 30MB |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/13439/console |


This message was automatically generated.



> Formalize coding standards for libhdfs++ and put them in a README.txt
> ---------------------------------------------------------------------
>
>                 Key: HDFS-9328
>                 URL: https://issues.apache.org/jira/browse/HDFS-9328
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>            Priority: Blocker
>         Attachments: HDFS-9328.HDFS-8707.000.patch, HDFS-9328.HDFS-8707.001.patch
>
>
> We have 2-3 people working on this project full time and hopefully more people will start
contributing.  In order to efficiently scale we need a single, easy to find, place where developers
can check to make sure they are following the coding standards of this project to both save
their time and save the time of people doing code reviews.
> The most practical place to do this seems like a README file in libhdfspp/. 
> The foundation of the standards is google's C++ guide found here: https://google-styleguide.googlecode.com/svn/trunk/cppguide.html
> Any exceptions to google's standards or additional restrictions need to be explicitly
enumerated so there is one single point of reference for all libhdfs++ code standards.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message