hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi Ozawa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9242) Fix Findbugs warning from webhdfs.DataNodeUGIProvider.ugiCache
Date Sun, 01 Nov 2015 15:25:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984419#comment-14984419
] 

Tsuyoshi Ozawa commented on HDFS-9242:
--------------------------------------

[~brahmareddy] [~liuml07] I think this is not false positive. For more detail. please check
this article: http://www.cs.umd.edu/~pugh/java/memoryModel/

A correct way to fix is to make ugiCache volatile. Could you update it?

> Fix Findbugs warning from webhdfs.DataNodeUGIProvider.ugiCache 
> ---------------------------------------------------------------
>
>                 Key: HDFS-9242
>                 URL: https://issues.apache.org/jira/browse/HDFS-9242
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Xiaoyu Yao
>            Assignee: Brahma Reddy Battula
>         Attachments: HDFS-9242.patch
>
>
> This was introduced by HDFS-8855 and pre-patch warning can be found at https://builds.apache.org/job/PreCommit-HDFS-Build/12975/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html#DC_DOUBLECHECK
> {code}
> Code	Warning
> DC	Possible doublecheck on org.apache.hadoop.hdfs.server.datanode.web.webhdfs.DataNodeUGIProvider.ugiCache
in new org.apache.hadoop.hdfs.server.datanode.web.webhdfs.DataNodeUGIProvider(ParameterParser,
Configuration)
> Bug type DC_DOUBLECHECK (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.web.webhdfs.DataNodeUGIProvider
> In method new org.apache.hadoop.hdfs.server.datanode.web.webhdfs.DataNodeUGIProvider(ParameterParser,
Configuration)
> On field org.apache.hadoop.hdfs.server.datanode.web.webhdfs.DataNodeUGIProvider.ugiCache
> At DataNodeUGIProvider.java:[lines 49-51]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message