hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Clampffer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9228) libhdfs++ should respect NN retry configuration settings
Date Tue, 17 Nov 2015 16:40:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008979#comment-15008979
] 

James Clampffer commented on HDFS-9228:
---------------------------------------

Some comments, mostly small stuff:

It looks like RpcConnection::shared_from_this is called frequently but I wasn't able to find
a make_shared<RpcConnection> though maybe I just missed it.  If it isn't using std::make_shared
on the instance somewhere using shared_from_this is undefined behavior.

In rpc_connection.h there are several instances of a lambda capturing 'this' and a shared_ptr
to 'this'.  Is the shared_ptr there to keep things alive and this captured to call methods
without using shared_this->method?  If this is the case why not just use shared_this->method?
 Not a blocker I'm just curious.

Nits:
Some minor issues with coding standards (double slash instead of block style comments).  Not
a blocker but probably worth fixing now.

Factoring Request out of RpcConnection looks good but I'd like to have a short comments for
each class that says what their responsibilities are.  Google's guide says this as well though
we haven't really enforced that rule in the past; I've been trying to do that for all of my
new code.

Perhaps change Callback as typedefed in rpc_engine.h to "RpcCallback" or similar because I'm
guessing callbacks in other parts of the code will have different signatures.  I do think
the pattern of defining one sort of callback for a large portion of code makes life a lot
easier.

> libhdfs++ should respect NN retry configuration settings
> --------------------------------------------------------
>
>                 Key: HDFS-9228
>                 URL: https://issues.apache.org/jira/browse/HDFS-9228
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Bob Hansen
>            Assignee: Bob Hansen
>         Attachments: HDFS-9228.HDFS-8707.001.patch, HDFS-9228.HDFS-8707.002.patch, HDFS-9228.HDFS-8707.003.patch
>
>
> Handle the use case of temporary network or NN hiccups and have a configurable number
of retries for NN operations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message