hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kihwal Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9221) HdfsServerConstants#ReplicaState#getState should avoid calling values() since it creates a temporary array
Date Mon, 02 Nov 2015 15:08:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985361#comment-14985361
] 

Kihwal Lee commented on HDFS-9221:
----------------------------------

Cherry-picked to branch-2.7.

> HdfsServerConstants#ReplicaState#getState should avoid calling values() since it creates
a temporary array
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-9221
>                 URL: https://issues.apache.org/jira/browse/HDFS-9221
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: performance
>    Affects Versions: 2.7.1
>            Reporter: Staffan Friberg
>            Assignee: Staffan Friberg
>             Fix For: 3.0.0, 2.7.2
>
>         Attachments: HADOOP-9221.001.patch
>
>
> When the BufferDecoder in BlockListAsLongs converts the stored value to a ReplicaState
enum it calls ReplicaState.getState(int) unfortunately this method creates a ReplicaState[]
for each call since it calls ReplicaState.values().
> This patch creates a cached version of the values and thus avoid all allocation when
doing the conversion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message