hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6363) Improve concurrency while checking inclusion and exclusion of datanodes
Date Mon, 23 Nov 2015 01:52:10 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021353#comment-15021353
] 

Haohui Mai commented on HDFS-6363:
----------------------------------

The approach looks good to me overall. Can you please change volatile to AtomicReference?

> Improve concurrency while checking inclusion and exclusion of datanodes
> -----------------------------------------------------------------------
>
>                 Key: HDFS-6363
>                 URL: https://issues.apache.org/jira/browse/HDFS-6363
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>              Labels: BB2015-05-TBR
>         Attachments: HDFS-6363.patch
>
>
> HostFileManager holds two effectively immutable objects - includes and excludes. These
two objects can be safely published together using a volatile container instead of synchronizing
for all mutators and accessors.
> This improves the concurrency while using HostFileManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message