Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Sat, 31 Oct 2015 00:19:27 +0000 (UTC)
From: "Haohui Mai (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12908394.1445987833000.113970.1446250767880@Atlassian.JIRA>
In-Reply-To: <JIRA.12908394.1445987833000@Atlassian.JIRA>
References: <JIRA.12908394.1445987833000@Atlassian.JIRA>
 <JIRA.12908394.1445987833052@arcas>
Subject: [jira] [Commented] (HDFS-9320) libhdfspp should not use sizeof for
 stream parsing
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983669#comment-14983669 ] 

Haohui Mai commented on HDFS-9320:
----------------------------------

{code}
+const unsigned int kSizeofJavaShort = 2;
+const unsigned int kSizeofJavaInt = 4;
+
{code}

should be inlined as {{sizeof(uint16_t)}} and {{sizeof(uint32_t)}} respectively. Other than that it looks good to me.


> libhdfspp should not use sizeof for stream parsing
> --------------------------------------------------
>
>                 Key: HDFS-9320
>                 URL: https://issues.apache.org/jira/browse/HDFS-9320
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Bob Hansen
>            Assignee: James Clampffer
>         Attachments: HDFS-9320.HDFS-8707.000.patch
>
>
> In a few places, we're using sizeof(int) and sizeof(short) to determine where in the received buffers we should be looking for data.  Those values are compiler- and platform-dependent.  We should use specified sizes, or at least sizeof(int32_t).


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)