Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 27 Oct 2015 01:01:32 +0000 (UTC)
From: "Mingliang Liu (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12908075.1445905531000.66518.1445907692305@Atlassian.JIRA>
In-Reply-To: <JIRA.12908075.1445905531000@Atlassian.JIRA>
References: <JIRA.12908075.1445905531000@Atlassian.JIRA>
 <JIRA.12908075.1445905531404@arcas>
Subject: [jira] [Commented] (HDFS-9313) Possible NullPointerException in
 BlockManager if no excess replica can be chosen
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-9313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975453#comment-14975453 ] 

Mingliang Liu commented on HDFS-9313:
-------------------------------------

Thanks for filing and working on this, [~mingma]. I think the patch makes sense to me. The warning is much better than a NPE.

{code}
+    // no replica can't be chosen as the excessive replica as
{code}
Do you mean "no replica *can* be chosen as the excessive replica as"?

> Possible NullPointerException in BlockManager if no excess replica can be chosen
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-9313
>                 URL: https://issues.apache.org/jira/browse/HDFS-9313
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: HDFS-9313.patch
>
>
> HDFS-8647 makes it easier to reason about various block placement scenarios. Here is one possible case where BlockManager won't be able to find the excess replica to delete: when storage policy changes around the same time balancer moves the block. When this happens, it will cause NullPointerException.
> {noformat}
> java.lang.NullPointerException
> 	at org.apache.hadoop.hdfs.server.blockmanagement.BlockPlacementPolicy.adjustSetsWithChosenReplica(BlockPlacementPolicy.java:156)
> 	at org.apache.hadoop.hdfs.server.blockmanagement.BlockPlacementPolicyDefault.chooseReplicasToDelete(BlockPlacementPolicyDefault.java:978)
> {noformat}
> Note that it isn't found in any production clusters. Instead, it is found from new unit tests. In addition, the issue has been there before HDFS-8647.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)