Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5A81E188D9 for ; Mon, 26 Oct 2015 21:58:44 +0000 (UTC) Received: (qmail 1887 invoked by uid 500); 26 Oct 2015 21:58:28 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 1674 invoked by uid 500); 26 Oct 2015 21:58:28 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 1651 invoked by uid 99); 26 Oct 2015 21:58:28 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Oct 2015 21:58:28 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1142F2C033A for ; Mon, 26 Oct 2015 21:58:28 +0000 (UTC) Date: Mon, 26 Oct 2015 21:58:27 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9304) Add HdfsClientConfigKeys class to TestHdfsConfigFields#configurationClasses MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975181#comment-14975181 ] Hudson commented on HDFS-9304: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #587 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/587/]) HDFS-9304. Add HdfsClientConfigKeys class to (wheat9: rev 67e3d75aed1c1a90cabffc552d5743a69ea28b54) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Add HdfsClientConfigKeys class to TestHdfsConfigFields#configurationClasses > --------------------------------------------------------------------------- > > Key: HDFS-9304 > URL: https://issues.apache.org/jira/browse/HDFS-9304 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: build > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Fix For: 2.8.0 > > Attachments: HDFS-9304.000.patch > > > *tl;dr* Since {{HdfsClientConfigKeys}} holds client side config keys, we need to add this class to {{TestHdfsConfigFields#configurationClasses}}. > Now the {{TestHdfsConfigFields}} unit test passes because {{DFSConfigKeys}} still contains all the client side config keys, though marked @deprecated. As we add new client config keys (e.g. [HDFS-9259]), the unit test will fail with the following error: > {quote} > hdfs-default.xml has 1 properties missing in class org.apache.hadoop.hdfs.DFSConfigKeys > {quote} > If the logic is to make the {{DFSConfigKeys}} and {{HdfsClientConfigKeys}} together cover all config keys in {{hdfs-default.xml}}, we need to put both of them in {{TestHdfsConfigFields#configurationClasses}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)