Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E69CD17B4B for ; Fri, 30 Oct 2015 03:38:46 +0000 (UTC) Received: (qmail 40588 invoked by uid 500); 30 Oct 2015 03:38:31 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 40541 invoked by uid 500); 30 Oct 2015 03:38:31 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 40530 invoked by uid 99); 30 Oct 2015 03:38:31 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Oct 2015 03:38:31 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D22222C1F5B for ; Fri, 30 Oct 2015 03:38:27 +0000 (UTC) Date: Fri, 30 Oct 2015 03:38:27 +0000 (UTC) From: "Walter Su (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-9275) Wait previous ErasureCodingWork to finish before schedule another one MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Su updated HDFS-9275: ---------------------------- Attachment: HDFS-9275.05.patch Thanks, [~hitliuyi]. bq. Also check this in scheduleRecovery to avoid unnecessary choose targets. Good idea. I moved it to {{scheduleRecovery}}. bq. move the block group to end of queue of same priority in neededReplications, otherwise it's chosen first again next time. Don't have to. {{UnderReplicatedBlocks}} has a inside bookmark. Uploaded 05 patch. > Wait previous ErasureCodingWork to finish before schedule another one > --------------------------------------------------------------------- > > Key: HDFS-9275 > URL: https://issues.apache.org/jira/browse/HDFS-9275 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Walter Su > Assignee: Walter Su > Attachments: HDFS-9275.01.patch, HDFS-9275.02.patch, HDFS-9275.03.patch, HDFS-9275.04.patch, HDFS-9275.05.patch > > > In {{ErasureCodingWorker}}, for the same block group, one task doesn't know which internal blocks is in recovering by other tasks. We could end up with recovering 2 identical block with same index. So, {{ReplicationMonitor}} should wait previous work to finish before schedule another one. > This is related to the occasional failure of {{TestRecoverStripedFile}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)