Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 47F4918116 for ; Mon, 19 Oct 2015 23:30:28 +0000 (UTC) Received: (qmail 55324 invoked by uid 500); 19 Oct 2015 23:30:28 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 55263 invoked by uid 500); 19 Oct 2015 23:30:28 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 55243 invoked by uid 99); 19 Oct 2015 23:30:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Oct 2015 23:30:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BFA982C1F6B for ; Mon, 19 Oct 2015 23:30:27 +0000 (UTC) Date: Mon, 19 Oct 2015 23:30:27 +0000 (UTC) From: "Colin Patrick McCabe (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9251) Refactor TestWriteToReplica and TestFsDatasetImpl to avoid explicitly creating Files in tests code. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964246#comment-14964246 ] Colin Patrick McCabe commented on HDFS-9251: -------------------------------------------- +1 pending Jenkins. Thanks, [~eddyxu]. > Refactor TestWriteToReplica and TestFsDatasetImpl to avoid explicitly creating Files in tests code. > --------------------------------------------------------------------------------------------------- > > Key: HDFS-9251 > URL: https://issues.apache.org/jira/browse/HDFS-9251 > Project: Hadoop HDFS > Issue Type: Improvement > Components: HDFS > Affects Versions: 2.7.1 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Attachments: HDFS-9251.00.patch, HDFS-9251.01.patch, HDFS-9251.02.patch > > > In {{TestWriteToReplica}} and {{TestFsDatasetImpl}}, tests directly creates block and metadata files: > {code} > replicaInfo.getBlockFile().createNewFile(); > replicaInfo.getMetaFile().createNewFile(); > {code} > It leaks the implementation details of {{FsDatasetImpl}}. This JIRA proposes to use {{FsDatasetImplTestUtils}} (HDFS-9188) to create replicas. -- This message was sent by Atlassian JIRA (v6.3.4#6332)