Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Sun, 11 Oct 2015 05:52:05 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12840908.1435336329000.8494.1444542725597@Atlassian.JIRA>
In-Reply-To: <JIRA.12840908.1435336329000@Atlassian.JIRA>
References: <JIRA.12840908.1435336329000@Atlassian.JIRA>
 <JIRA.12840908.1435336329622@arcas>
Subject: [jira] [Commented] (HDFS-8676) Delayed rolling upgrade finalization
 can cause heartbeat expiration
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952163#comment-14952163 ] 

Hadoop QA commented on HDFS-8676:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  25m 11s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   9m 37s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  10m 54s | There were no new javadoc warning messages. |
| {color:red}-1{color} | release audit |   0m 17s | The applied patch generated 1 release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m 45s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 37s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   2m 38s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native |   3m 28s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 224m 30s | Tests passed in hadoop-hdfs. |
| | | 280m 37s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12765752/HDFS-8676.02.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 7e2c971 |
| Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/12923/artifact/patchprocess/patchReleaseAuditProblems.txt |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12923/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12923/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12923/console |


This message was automatically generated.

> Delayed rolling upgrade finalization can cause heartbeat expiration
> -------------------------------------------------------------------
>
>                 Key: HDFS-8676
>                 URL: https://issues.apache.org/jira/browse/HDFS-8676
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Kihwal Lee
>            Assignee: Walter Su
>            Priority: Critical
>         Attachments: HDFS-8676.01.patch, HDFS-8676.02.patch
>
>
> In big busy clusters where the deletion rate is also high, a lot of blocks can pile up in the datanode trash directories until an upgrade is finalized.  When it is finally finalized, the deletion of trash is done in the service actor thread's context synchronously.  This blocks the heartbeat and can cause heartbeat expiration.  
> We have seen a namenode losing hundreds of nodes after a delayed upgrade finalization.  The deletion of trash directories should be made asynchronous.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)