Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 23 Oct 2015 05:04:27 +0000 (UTC)
From: "Yongjun Zhang (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12750289.1414133524000.36399.1445576667711@Atlassian.JIRA>
In-Reply-To: <JIRA.12750289.1414133524000@Atlassian.JIRA>
References: <JIRA.12750289.1414133524000@Atlassian.JIRA>
 <JIRA.12750289.1414133524383@arcas>
Subject: [jira] [Commented] (HDFS-7284) Add more debug info to
 BlockInfoUnderConstruction#setGenerationStampAndVerifyReplicas
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970448#comment-14970448 ] 

Yongjun Zhang commented on HDFS-7284:
-------------------------------------

Thanks [~andrew.wang], nice comments.

I realize I made a mistake, there is no easy way to call {{Block#toString()}} from object {{r}} of {{ReplicaUnderConstruction}} class, doing a cast like I suggested earlier wouldn't work.


> Add more debug info to BlockInfoUnderConstruction#setGenerationStampAndVerifyReplicas
> -------------------------------------------------------------------------------------
>
>                 Key: HDFS-7284
>                 URL: https://issues.apache.org/jira/browse/HDFS-7284
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.5.1
>            Reporter: Hu Liu,
>            Assignee: Wei-Chiu Chuang
>         Attachments: HDFS-7284.001.patch
>
>
> When I was looking at some replica loss issue, I got the following info from log
> {code}
> 2014-10-13 01:54:53,104 INFO BlockStateChange: BLOCK* Removing stale replica from location x.x.x.x
> {code}
> I could just know that a replica is removed, but I don't know which block and its timestamp. I need to know the id and timestamp of the block from the log file.
> So it's better to add more info including block id and timestamp to the code snippet
> {code}
>     for (ReplicaUnderConstruction r : replicas) {
>       if (genStamp != r.getGenerationStamp()) {
>         r.getExpectedLocation().removeBlock(this);
>         NameNode.blockStateChangeLog.info("BLOCK* Removing stale replica "
>             + "from location: " + r.getExpectedLocation());
>       }
>     }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)