hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9320) libhdfspp should not use sizeof for stream parsing
Date Sat, 31 Oct 2015 00:19:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983669#comment-14983669
] 

Haohui Mai commented on HDFS-9320:
----------------------------------

{code}
+const unsigned int kSizeofJavaShort = 2;
+const unsigned int kSizeofJavaInt = 4;
+
{code}

should be inlined as {{sizeof(uint16_t)}} and {{sizeof(uint32_t)}} respectively. Other than
that it looks good to me.


> libhdfspp should not use sizeof for stream parsing
> --------------------------------------------------
>
>                 Key: HDFS-9320
>                 URL: https://issues.apache.org/jira/browse/HDFS-9320
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Bob Hansen
>            Assignee: James Clampffer
>         Attachments: HDFS-9320.HDFS-8707.000.patch
>
>
> In a few places, we're using sizeof(int) and sizeof(short) to determine where in the
received buffers we should be looking for data.  Those values are compiler- and platform-dependent.
 We should use specified sizes, or at least sizeof(int32_t).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message