hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9304) Add HdfsClientConfigKeys class to TestHdfsConfigFields#configurationClasses
Date Mon, 26 Oct 2015 19:09:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974847#comment-14974847

Mingliang Liu commented on HDFS-9304:

Thanks to [~wheat9] for your review and commit.

> Add HdfsClientConfigKeys class to TestHdfsConfigFields#configurationClasses
> ---------------------------------------------------------------------------
>                 Key: HDFS-9304
>                 URL: https://issues.apache.org/jira/browse/HDFS-9304
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>             Fix For: 2.8.0
>         Attachments: HDFS-9304.000.patch
> *tl;dr* Since {{HdfsClientConfigKeys}} holds client side config keys, we need to add
this class to {{TestHdfsConfigFields#configurationClasses}}.
> Now the {{TestHdfsConfigFields}} unit test passes because {{DFSConfigKeys}} still contains
all the client side config keys, though marked @deprecated. As we add new client config keys
(e.g. [HDFS-9259]), the unit test will fail with the following error:
> {quote}
> hdfs-default.xml has 1 properties missing in  class org.apache.hadoop.hdfs.DFSConfigKeys
> {quote}
> If the logic is to make the {{DFSConfigKeys}} and {{HdfsClientConfigKeys}} together cover
all config keys in {{hdfs-default.xml}}, we need to put both of them in {{TestHdfsConfigFields#configurationClasses}}.

This message was sent by Atlassian JIRA

View raw message