hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lei (Eddy) Xu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-9251) Refactor TestWriteToReplica and TestFsDatasetImpl to avoid explicitly creating Files in tests code.
Date Tue, 20 Oct 2015 17:10:27 GMT

     [ https://issues.apache.org/jira/browse/HDFS-9251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lei (Eddy) Xu updated HDFS-9251:
--------------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 2.8.0
                   3.0.0
           Status: Resolved  (was: Patch Available)

Thanks for the feedbacks and reviews, [~cmccabe].

Committed to trunk and branch-2.

> Refactor TestWriteToReplica and TestFsDatasetImpl to avoid explicitly creating Files
in tests code.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-9251
>                 URL: https://issues.apache.org/jira/browse/HDFS-9251
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: HDFS
>    Affects Versions: 2.7.1
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>             Fix For: 3.0.0, 2.8.0
>
>         Attachments: HDFS-9251.00.patch, HDFS-9251.01.patch, HDFS-9251.02.patch
>
>
> In {{TestWriteToReplica}} and {{TestFsDatasetImpl}}, tests directly creates block and
metadata files:
> {code}
> replicaInfo.getBlockFile().createNewFile();
> replicaInfo.getMetaFile().createNewFile();
> {code}
> It leaks the implementation details of {{FsDatasetImpl}}. This JIRA proposes to use {{FsDatasetImplTestUtils}}
(HDFS-9188) to create replicas. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message