hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9251) Refactor TestWriteToReplica and TestFsDatasetImpl to avoid explicitly creating Files in tests code.
Date Mon, 19 Oct 2015 23:30:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964246#comment-14964246
] 

Colin Patrick McCabe commented on HDFS-9251:
--------------------------------------------

+1 pending Jenkins.  Thanks, [~eddyxu].

> Refactor TestWriteToReplica and TestFsDatasetImpl to avoid explicitly creating Files
in tests code.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-9251
>                 URL: https://issues.apache.org/jira/browse/HDFS-9251
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: HDFS
>    Affects Versions: 2.7.1
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HDFS-9251.00.patch, HDFS-9251.01.patch, HDFS-9251.02.patch
>
>
> In {{TestWriteToReplica}} and {{TestFsDatasetImpl}}, tests directly creates block and
metadata files:
> {code}
> replicaInfo.getBlockFile().createNewFile();
> replicaInfo.getMetaFile().createNewFile();
> {code}
> It leaks the implementation details of {{FsDatasetImpl}}. This JIRA proposes to use {{FsDatasetImplTestUtils}}
(HDFS-9188) to create replicas. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message