hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9223) Code cleanup for DatanodeDescriptor and HeartbeatManager
Date Tue, 13 Oct 2015 20:40:09 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955619#comment-14955619
] 

Hadoop QA commented on HDFS-9223:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  18m 41s | Pre-patch trunk has 1 extant Findbugs (version
3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 4 new
or modified test files. |
| {color:green}+1{color} | javac |   8m 20s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  10m 33s | There were no new javadoc warning messages.
|
| {color:red}-1{color} | release audit |   0m 19s | The applied patch generated 1 release
audit warnings. |
| {color:red}-1{color} | checkstyle |   1m 25s | The applied patch generated  4 new checkstyle
issues (total was 329, now 319). |
| {color:red}-1{color} | whitespace |   0m  2s | The patch has 2  line(s) that end in whitespace.
Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 35s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   2m 31s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | native |   3m 16s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests |  64m 14s | Tests failed in hadoop-hdfs. |
| | | 111m 32s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.blockmanagement.TestNodeCount |
|   | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks |
|   | hadoop.hdfs.server.namenode.TestFileTruncate |
|   | hadoop.hdfs.TestRollingUpgrade |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12766371/HDFS-9223.002.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / da16c9b |
| Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/12956/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
|
| Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/12956/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| checkstyle |  https://builds.apache.org/job/PreCommit-HDFS-Build/12956/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/12956/artifact/patchprocess/whitespace.txt
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12956/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12956/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12956/console |


This message was automatically generated.

> Code cleanup for DatanodeDescriptor and HeartbeatManager
> --------------------------------------------------------
>
>                 Key: HDFS-9223
>                 URL: https://issues.apache.org/jira/browse/HDFS-9223
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-9223.000.patch, HDFS-9223.001.patch, HDFS-9223.002.patch
>
>
> Some code cleanup for {{DatanodeDescriptor}} and {{HeartbeatManager}}. The changes include:
> # Change {{DataDescriptor#isAlive}} and {{DatanodeDescriptor#needKeyUpdate}} from public
to private
> # Use EnumMap for {{HeartbeatManager#storageTypeStatesMap}}
> # Move the {{isInStartupSafeMode}} out of the namesystem lock in {{heartbeatCheck}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message