hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9223) Code cleanup for DatanodeDescriptor and HeartbeatManager
Date Mon, 12 Oct 2015 20:59:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953715#comment-14953715
] 

Jing Zhao commented on HDFS-9223:
---------------------------------

For {{heartbeatCheck}}, currently the {{dead}} node object is retrieved from the heartbeatManager's
own datanode list, I'm not very sure if this list is always consistent with datanodeManager's
datanodeMap. I will check this code to confirm and maybe we can do this change separately.

> Code cleanup for DatanodeDescriptor and HeartbeatManager
> --------------------------------------------------------
>
>                 Key: HDFS-9223
>                 URL: https://issues.apache.org/jira/browse/HDFS-9223
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-9223.000.patch, HDFS-9223.001.patch
>
>
> Some code cleanup for {{DatanodeDescriptor}} and {{HeartbeatManager}}. The changes include:
> # Change {{DataDescriptor#isAlive}} and {{DatanodeDescriptor#needKeyUpdate}} from public
to private
> # Use EnumMap for {{HeartbeatManager#storageTypeStatesMap}}
> # Move the {{isInStartupSafeMode}} out of the namesystem lock in {{heartbeatCheck}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message