hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Payne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9181) Better handling of exceptions thrown during upgrade shutdown
Date Fri, 09 Oct 2015 18:18:09 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950916#comment-14950916
] 

Eric Payne commented on HDFS-9181:
----------------------------------

{quote}
I committed rev 004 to trunk and branch-2. Thanks Wei-Chiu for the contribution, and all for
the review.

Just saw Wei-Chiu uploaded a new rev 005 with some refactoring. Suggest to create follow-up
jira and do the refactoring when fixing another issue in same area.
{quote}
I agree with [~yzhangal]'s suggestion to make the refactoring task a separate JIRA. I believe
that it is much easier to review changes when they are focused on one issue. In fact, if refactoring
is to be done, I would rather that it be done by itself rather than with any other changes.

> Better handling of exceptions thrown during upgrade shutdown
> ------------------------------------------------------------
>
>                 Key: HDFS-9181
>                 URL: https://issues.apache.org/jira/browse/HDFS-9181
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>            Priority: Minor
>              Labels: supportability
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9181.002.patch, HDFS-9181.003.patch, HDFS-9181.004.patch, HDFS-9181.005.patch
>
>
> Previously in HDFS-7533, a bug was fixed by suppressing exceptions during upgrade shutdown.
It may be appropriate as a temporary fix, but it would be better if the exception is handled
in some other ways.
> One way to handle it is by emitting a warning message. There could exist other ways to
handle it. This jira is created to discuss how to handle this case better.
> Thanks to [~templedf] for bringing this up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message