hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9181) Better handling of exceptions thrown during upgrade shutdown
Date Tue, 06 Oct 2015 14:27:26 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945100#comment-14945100

Wei-Chiu Chuang commented on HDFS-9181:

Thanks to [~templedf] and [~eepayne] for the discussion.
Catching Throwable is generally regarded as an undesirable practice (See http://stackoverflow.com/questions/17333925/is-it-ok-to-catch-throwable-for-performing-cleanup
and http://stackoverflow.com/questions/6083248/is-it-a-bad-practice-to-catch-throwable)

My only question is, if we go for catching the Exception, is it ok to silently ignore it?

> Better handling of exceptions thrown during upgrade shutdown
> ------------------------------------------------------------
>                 Key: HDFS-9181
>                 URL: https://issues.apache.org/jira/browse/HDFS-9181
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>            Priority: Minor
> Previously in HDFS-7533, a bug was fixed by suppressing exceptions during upgrade shutdown.
It may be appropriate as a temporary fix, but it would be better if the exception is handled
in some other ways.
> One way to handle it is by emitting a warning message. There could exist other ways to
handle it. This jira is created to discuss how to handle this case better.
> Thanks to [~templedf] for bringing this up.

This message was sent by Atlassian JIRA

View raw message