hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nijel (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9157) [OEV and OIV] : Unnecessary parsing for mandatory arguements if "-h" option is specified as the only option
Date Fri, 09 Oct 2015 05:03:26 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949897#comment-14949897
] 

nijel commented on HDFS-9157:
-----------------------------

bq.-1	release audit
Not related to this patch

bq.-1	hdfs tests
As per my analysis, these are not related to the patch

thanks

> [OEV and OIV] : Unnecessary parsing for mandatory arguements if "-h" option is specified
as the only option
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-9157
>                 URL: https://issues.apache.org/jira/browse/HDFS-9157
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: nijel
>            Assignee: nijel
>         Attachments: HDFS-9157_1.patch
>
>
> In both tools, if "-h" is specified as the only option, it throws error as input and
output not specified.
> {noformat}
> master:/home/nijel/hadoop-3.0.0-SNAPSHOT/bin # ./hdfs oev -h
> Error parsing command-line options: Missing required options: o, i
> Usage: bin/hdfs oev [OPTIONS] -i INPUT_FILE -o OUTPUT_FILE
> {noformat}
> In code the parsing is happening before the "-h" option is verified
> Can add code to return after initial check.
> {code}
>     if (argv.length == 1 && argv[1] == "-h") {
>       printHelp();
>       return 0;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message