hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9145) Tracking methods that hold FSNamesytemLock for too long
Date Mon, 12 Oct 2015 21:19:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953755#comment-14953755
] 

Jing Zhao commented on HDFS-9145:
---------------------------------

The patch looks good to me. One minor optional thing to do is to use a boolean capturing whether
to log first, and do the real log out of the lock. Another nit is that in the warning message,
we can add a newline before the stack trace msg. Other than this +1.

> Tracking methods that hold FSNamesytemLock for too long
> -------------------------------------------------------
>
>                 Key: HDFS-9145
>                 URL: https://issues.apache.org/jira/browse/HDFS-9145
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Jing Zhao
>            Assignee: Mingliang Liu
>         Attachments: HDFS-9145.000.patch, HDFS-9145.001.patch, HDFS-9145.002.patch
>
>
> It will be helpful that if we can have a way to track (or at least log a msg) if some
operation is holding the FSNamesystem lock for a long time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message