hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager
Date Mon, 26 Oct 2015 20:49:28 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975016#comment-14975016
] 

Anu Engineer commented on HDFS-9129:
------------------------------------

[~liuml07] Thanks for adding me to this review. It looks like  the patch-10 does indeed break
HDFS-4015. The issue might be a missing line in {{FSNamesystem#setSafeMode}}. We seems to
have dropped a line safeMode.leave(true), in the SAFEMODE_FORCE_EXIT along with setting leaveSafeMode
function always calling blockManager.leaveSafeMode(true);

Since you are refactoring all the safemode related variables into one class, I think it might
be a good idea to move BytesInFutureBlocks also to the same class.



> Move the safemode block count into BlockManager
> -----------------------------------------------
>
>                 Key: HDFS-9129
>                 URL: https://issues.apache.org/jira/browse/HDFS-9129
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Haohui Mai
>            Assignee: Mingliang Liu
>         Attachments: HDFS-9129.000.patch, HDFS-9129.001.patch, HDFS-9129.002.patch, HDFS-9129.003.patch,
HDFS-9129.004.patch, HDFS-9129.005.patch, HDFS-9129.006.patch, HDFS-9129.007.patch, HDFS-9129.008.patch,
HDFS-9129.009.patch, HDFS-9129.010.patch
>
>
> The {{SafeMode}} needs to track whether there are enough blocks so that the NN can get
out of the safemode. These fields can moved to the {{BlockManager}} class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message