hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "J.Andreina (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9070) Allow fsck display pending replica location information for being-written blocks
Date Fri, 09 Oct 2015 09:36:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950132#comment-14950132
] 

J.Andreina commented on HDFS-9070:
----------------------------------

Hi [~demongaorui] ,thanks for the patch. It looks good overall . I have few comments. 

1.
   In last patch , we are printing the under construction block information only if the user
sets "showLocations" to true.
   We can remove the check for showLocations in below code, to be consistent with the behavior
in finalized blocks.
{code}	   
       if (!blocks.isLastBlockComplete() && lastBlock != null && showLocations)
{
	      report.append('\n');
	      report.append("Under Construction Block:\n");
{code}

2.
  There are possibilities that while the last block is under-construction , the node is getting
into decommissioning state. 
So the possible replica state , when the block is under-construction could be :
	*Decommissioning*
	*STALE_NODE*
	*STALE_BLOCK_CONTENT*
	*LIVE*

So i feel it would be good , if we can show the rackinfo and replica informations as well.

We can extract the existing finalized-block's code for the check on (showLocations || showRacks
|| showReplicaDetails ) to a method and can reuse the code for under-construction block also.


> Allow fsck display pending replica location information for being-written blocks
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-9070
>                 URL: https://issues.apache.org/jira/browse/HDFS-9070
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: GAO Rui
>            Assignee: GAO Rui
>         Attachments: HDFS-9070--HDFS-7285.00.patch, HDFS-9070-HDFS-7285.00.patch, HDFS-9070-HDFS-7285.01.patch,
HDFS-9070-HDFS-7285.02.patch, HDFS-9070-trunk.03.patch, HDFS-9070-trunk.04.patch
>
>
> When a EC file is being written, it can be helpful to allow fsck display datanode information
of the being-written EC file block group. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message