hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8777) Erasure Coding: add tests for taking snapshots on EC files
Date Thu, 29 Oct 2015 19:10:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981077#comment-14981077
] 

Zhe Zhang commented on HDFS-8777:
---------------------------------

Thanks Rakesh for the patch! It looks good overall. A few minor comments:
# Maybe explicitly use {{sysDefaultPolicy}} in all {{setErasureCodingPolicy}} calls in this
test? Now there's a mix of {{sysDefaultPolicy}} and null.
# Missing "coding": "// Now delete the dir which has erasure policy."
# In section "// Check that older snapshots still have the old ECPolicy settings", should
we also verify {{snap2}}?
# The below verifies the EC policy on a non-existent file. It looks like a bug in {{getErasureCodingPolicy}}.
Actually it looks like {{getEncryptionZoneForPath}} has the same behavior. 
{code}
    final Path snap1File = new Path(snap1, "file1");
    assertEquals("Got unexpected erasure coding policy", sysDefaultPolicy,
        fs.getErasureCodingPolicy(snap1File));
{code}
# As a follow-on, we can explore whether it's possible to subclass {{TestSnapshot}} with {{setErasureCodingPolicy}}
hooks. I'm not sure how hard it is, just a thought.

> Erasure Coding: add tests for taking snapshots on EC files
> ----------------------------------------------------------
>
>                 Key: HDFS-8777
>                 URL: https://issues.apache.org/jira/browse/HDFS-8777
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding
>            Reporter: Jing Zhao
>            Assignee: Rakesh R
>              Labels: test
>         Attachments: HDFS-8777-01.patch, HDFS-8777-02.patch, HDFS-8777-HDFS-7285-00.patch,
HDFS-8777-HDFS-7285-01.patch
>
>
> We need to add more tests for (EC + snapshots). The tests need to verify the fsimage
saving/loading is correct.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message