hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8766) Implement a libhdfs(3) compatible API
Date Wed, 28 Oct 2015 00:30:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977458#comment-14977458
] 

Haohui Mai commented on HDFS-8766:
----------------------------------

Sorry looked at the wrong patch. Good work, [~James Clampffer]!

Some minor issues:

{code}
+/*
+  C API implementations
+*/
{code}

It might make more sense to make it into the following:

{code}
+/**
+ * C API implementations
+ **/
{code}

to make it consistent with the rest of the code in the repository (both C++ and Java)

{code}
+using namespace hdfs;
+/* Seperate the handles used by the C api from the C++ API*/
{code}

It's a bad idea to put {{using namespace}} into the header file.

> Implement a libhdfs(3) compatible API
> -------------------------------------
>
>                 Key: HDFS-8766
>                 URL: https://issues.apache.org/jira/browse/HDFS-8766
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>         Attachments: HDFS-8766.HDFS-8707.000.patch, HDFS-8766.HDFS-8707.001.patch, HDFS-8766.HDFS-8707.002.patch,
HDFS-8766.HDFS-8707.003.patch, HDFS-8766.HDFS-8707.004.patch, HDFS-8766.HDFS-8707.005.patch,
HDFS-8766.HDFS-8707.006.patch, HDFS-8766.HDFS-8707.007.patch, HDFS-8766.HDFS-8707.008.patch,
HDFS-8766.HDFS-8707.009.patch, HDFS-8766.HDFS-8707.010.patch
>
>
> Add a synchronous API that is compatible with the hdfs.h header used in libhdfs and libhdfs3.
 This will make it possible for projects using libhdfs/libhdfs3 to relink against libhdfspp
with minimal changes.
> This also provides a pure C interface that can be linked against projects that aren't
built in C++11 mode for various reasons but use the same compiler.  It also allows many other
programming languages to access libhdfspp through builtin FFI interfaces.
> The libhdfs API is very similar to the posix file API which makes it easier for programs
built using posix filesystem calls to be modified to access HDFS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message