Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 24 Sep 2015 08:40:04 +0000 (UTC)
From: "Yi Liu (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12896008.1443074104000.60347.1443084004312@Atlassian.JIRA>
In-Reply-To: <JIRA.12896008.1443074104000@Atlassian.JIRA>
References: <JIRA.12896008.1443074104000@Atlassian.JIRA>
 <JIRA.12896008.1443074104290@arcas>
Subject: [jira] [Commented] (HDFS-9137) DeadLock between
 DataNode#refreshVolumes and BPOfferService#registrationSucceeded
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-9137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906020#comment-14906020 ] 

Yi Liu commented on HDFS-9137:
------------------------------

Thanks Uma, agree with that it's potential risk that can cause deadlock.  
It's dangerous to have lock in {{toString()}} implementation, this function is called sometimes but you may not notice.

> DeadLock between DataNode#refreshVolumes and BPOfferService#registrationSucceeded 
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-9137
>                 URL: https://issues.apache.org/jira/browse/HDFS-9137
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.0.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>
> I can see this code flows between DataNode#refreshVolumes and BPOfferService#registrationSucceeded could cause deadLock.
> In practice situation may be rare as user calling refreshVolumes at the time DN registration with NN. But seems like issue can happen.
>  Reason for deadLock:
>   1) refreshVolumes will be called with DN lock and after at the end it will also trigger Block report. In the Block report call, BPServiceActor#triggerBlockReport calls toString on bpos. Here it takes readLock on bpos.
>  DN lock then boos lock
> 2) BPOfferSetrvice#registrationSucceeded call is taking writeLock on bpos and  calling dn.bpRegistrationSucceeded which is again synchronized call on DN.
> bpos lock and then DN lock.
> So, this can clearly create dead lock.
> I think simple fix could be to move triggerBlockReport call outside out DN lock and I feel that call may not be really needed inside DN lock.
> Thoughts?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)