Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 22 Sep 2015 13:39:05 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12888662.1442609611000.38695.1442929145213@Atlassian.JIRA>
In-Reply-To: <JIRA.12888662.1442609611000@Atlassian.JIRA>
References: <JIRA.12888662.1442609611000@Atlassian.JIRA>
 <JIRA.12888662.1442609611869@arcas>
Subject: [jira] [Commented] (HDFS-9110) Improve upon HDFS-8480
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902625#comment-14902625 ] 

Hadoop QA commented on HDFS-9110:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12761641/HDFS-9110.03.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 57003fa |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12593/console |


This message was automatically generated.

> Improve upon HDFS-8480
> ----------------------
>
>                 Key: HDFS-9110
>                 URL: https://issues.apache.org/jira/browse/HDFS-9110
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.7.0
>            Reporter: Charlie Helin
>            Assignee: Charlie Helin
>            Priority: Minor
>             Fix For: 2.7.0, 2.6.1
>
>         Attachments: HDFS-9110.00.patch, HDFS-9110.01.patch, HDFS-9110.02.patch, HDFS-9110.03.patch
>
>
> This is a request to do some cosmetic improvements on top of HDFS-8480. There a couple of File -> java.nio.file.Path conversions which is a little bit distracting. 
> The second aspect is more around efficiency, to be perfectly honest I'm not sure what the number of files that may be processed. However as HDFS-8480 eludes to it appears that this number could be significantly large. 
> The current implementation is basically a collect and process where all files first is being examined; put into a collection and after that processed. HDFS-8480 could simply be further enhanced by employing a single iteration without creating an intermediary collection of filenames by using a FileWalker


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)