Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 22 Sep 2015 19:04:04 +0000 (UTC)
From: "Anu Engineer (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12888659.1442608898000.42215.1442948644388@Atlassian.JIRA>
In-Reply-To: <JIRA.12888659.1442608898000@Atlassian.JIRA>
References: <JIRA.12888659.1442608898000@Atlassian.JIRA>
 <JIRA.12888659.1442608898658@arcas>
Subject: [jira] [Commented] (HDFS-9109) dfs.datanode.dns.interface does not
 work with hosts file based setups
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903232#comment-14903232 ] 

Anu Engineer commented on HDFS-9109:
------------------------------------

+1 (non-binding)

Had some minor nitpicks :
# In the DNS.java, we now have both java.net.InetAddress and com.google.common.net.InetAddresses. Hence you might want to consider renaming getIPsAsInetAddresses as something line getIPsAsInetAddressList since you are returning the one from java namespace-- same for the comments or you can stop using that guava class for IP Address verification.
# As for testing I was wondering if we might be able to leverage sun.net.spi.nameservice.NameService and provide our own DNS lookup service ? we do have to set the java system variables before the test gets run though. But as you said it might be something that we can consider for future.


> dfs.datanode.dns.interface does not work with hosts file based setups
> ---------------------------------------------------------------------
>
>                 Key: HDFS-9109
>                 URL: https://issues.apache.org/jira/browse/HDFS-9109
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-9109.01.patch, HDFS-9109.02.patch, HDFS-9109.03.patch
>
>
> The configuration setting {{dfs.datanode.dns.interface}} lets the DataNode select its hostname by doing a reverse lookup of IP addresses on the specific network interface. This does not work {{when /etc/hosts}} is used to setup alternate hostnames, since {{DNS#reverseDns}} only queries the DNS servers.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)