Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6D9F2181B5 for ; Fri, 18 Sep 2015 00:05:05 +0000 (UTC) Received: (qmail 78553 invoked by uid 500); 18 Sep 2015 00:05:05 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 78488 invoked by uid 500); 18 Sep 2015 00:05:05 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 78469 invoked by uid 99); 18 Sep 2015 00:05:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Sep 2015 00:05:05 +0000 Date: Fri, 18 Sep 2015 00:05:04 +0000 (UTC) From: "Colin Patrick McCabe (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9080) update htrace version to 4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9080?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14804= 720#comment-14804720 ]=20 Colin Patrick McCabe commented on HDFS-9080: -------------------------------------------- Thanks for the review. bq. You want to add hostname+port to this name("FSClient").? ... at least a= s an annotation? It's automatically added by HTrace, depending on the configuration of {{tra= cer.id}}. bq. You change the names of the pb params but use old ids. Thats a no-no. A= dd the new params with new ids or, why not just note that you are stuffing = high and low into trace and span from 4.0.0 out... and RPC stays the same. Hmm, those names are never sent over the wire, just the positions and types= . But I guess I can leave them as-is. bq. Should TracerConfigurationManager do Sampler too? Or that can be anothe= r patch It definitely should, but that would be a new feature :) Right now you can= only change {{SpanReceivers}} via RPC, not {{Samplers}}. That's definitel= y an oversight we should fix in another patch. bq. Below import \[not\] needed in your doc. Fixed bq. Unused 32=09import org.apache.htrace.core.Tracer; in ClientContext? Fixed bq. I can see why you have Tracer as static on FileSystem. What will happen= in case where two FileSystems in same JVM? Not important I suppose.... (th= ere'll be no tracing in any setup =E2=80=93 unit test =E2=80=93 that does s= uch a thing). Thats fine. It'll be OK. The Tracer methods are thread-safe. bq. I suppose this is correct... assuming that the parent at position zero = is first parent.... Can it be null? (It throws exception in this case? A nu= ll parent down here would be an error?) No, it can't be null. > update htrace version to 4.0 > ---------------------------- > > Key: HDFS-9080 > URL: https://issues.apache.org/jira/browse/HDFS-9080 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.8.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-9080.001.patch, HDFS-9080.002.patch, HDFS-9080.= 003.patch, HDFS-9080.004.patch > > > Update the HTrace library version Hadoop uses to htrace 4.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)