Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3C52017C91 for ; Sun, 13 Sep 2015 00:57:47 +0000 (UTC) Received: (qmail 49997 invoked by uid 500); 13 Sep 2015 00:57:46 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 49930 invoked by uid 500); 13 Sep 2015 00:57:46 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 49918 invoked by uid 99); 13 Sep 2015 00:57:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Sep 2015 00:57:46 +0000 Date: Sun, 13 Sep 2015 00:57:46 +0000 (UTC) From: "Mingliang Liu (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-9022) Move NameNode.getAddress() and NameNode.getUri() to hadoop-hdfs-client MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-9022: -------------------------------- Attachment: HDFS-9022.002.patch Thank you [~wheat9] for your comments. The v2 patch addresses the method refinement which makes them more meaningful. > Move NameNode.getAddress() and NameNode.getUri() to hadoop-hdfs-client > ---------------------------------------------------------------------- > > Key: HDFS-9022 > URL: https://issues.apache.org/jira/browse/HDFS-9022 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client, namenode > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HDFS-9022.000.patch, HDFS-9022.001.patch, HDFS-9022.002.patch > > > The static helper methods in NameNodes are used in {{hdfs-client}} module. For example, it's used by the {{DFSClient}} and {{NameNodeProxies}} classes which are being moved to {{hadoop-hdfs-client}} module. Meanwhile, we should keep the {{NameNode}} class itself in the {{hadoop-hdfs}} module. > This jira tracks the effort of moving the following static helper methods out of {{NameNode}} and thus {{hadoop-hdfs}} module. A good place to put these methods is the {{DFSUtilClient}} class: > {code} > public static InetSocketAddress getAddress(String address); > public static InetSocketAddress getAddress(Configuration conf); > public static InetSocketAddress getAddress(URI filesystemURI); > public static URI getUri(InetSocketAddress namenode); > {code} > Be cautious not to bring new checkstyle warnings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)