Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 49A4917532 for ; Tue, 15 Sep 2015 18:43:00 +0000 (UTC) Received: (qmail 53996 invoked by uid 500); 15 Sep 2015 18:42:47 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 53945 invoked by uid 500); 15 Sep 2015 18:42:47 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 53764 invoked by uid 99); 15 Sep 2015 18:42:47 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Sep 2015 18:42:47 +0000 Date: Tue, 15 Sep 2015 18:42:47 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9008) Balancer#Parameters class could use a builder pattern MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745915#comment-14745915 ] Hudson commented on HDFS-9008: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #389 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/389/]) HDFS-9008. Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java > Balancer#Parameters class could use a builder pattern > ----------------------------------------------------- > > Key: HDFS-9008 > URL: https://issues.apache.org/jira/browse/HDFS-9008 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: balancer & mover > Reporter: Chris Trezzo > Assignee: Chris Trezzo > Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-9008-trunk-v1.patch, HDFS-9008-trunk-v2.patch, HDFS-9008-trunk-v3.patch, HDFS-9008-trunk-v4.patch, HDFS-9008-trunk-v5.patch > > > The Balancer#Parameters class is violating a few checkstyle rules. > # Instance variables are not privately scoped and do not have accessor methods. > # The Balancer#Parameter constructor has too many arguments (according to checkstyle). > Changing this class to use the builder pattern could fix both of these style issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)