Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 17 Sep 2015 20:05:04 +0000 (UTC)
From: "Lei (Eddy) Xu (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12861206.1441163038000.4600.1442520304755@Atlassian.JIRA>
In-Reply-To: <JIRA.12861206.1441163038000@Atlassian.JIRA>
References: <JIRA.12861206.1441163038000@Atlassian.JIRA>
 <JIRA.12861206.1441163038618@arcas>
Subject: [jira] [Commented] (HDFS-9004) Add upgrade domain to DatanodeInfo
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804388#comment-14804388 ] 

Lei (Eddy) Xu commented on HDFS-9004:
-------------------------------------

Hi, [~mingma]

You patch looks very good in general. 

It'd be great to address one small change: is the following change necessary in this patch?

{code:title=DFSTestUtil.java}
        1l, 2l, 3l, 4l, 0l, 0l, 0l, 5, 6, "local", adminState,
+	ipAddr + ":" + DFSConfigKeys.DFS_DATANODE_DEFAULT_PORT);
{code}

Will +1 once address the above comments and verify the tests failures are not relevant.

> Add upgrade domain to DatanodeInfo
> ----------------------------------
>
>                 Key: HDFS-9004
>                 URL: https://issues.apache.org/jira/browse/HDFS-9004
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: HDFS-9004-2.patch, HDFS-9004.patch
>
>
> As part of upgrade domain feature, we first need to add upgrade domain string to {{DatanodeInfo}}. It includes things like:
> * Add a new field to DatanodeInfo.
> * Modify protobuf for DatanodeInfo.
> * Update DatanodeInfo.getDatanodeReport to include upgrade domain.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)