Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8009F18B07 for ; Fri, 18 Sep 2015 06:24:04 +0000 (UTC) Received: (qmail 62981 invoked by uid 500); 18 Sep 2015 06:24:04 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 62925 invoked by uid 500); 18 Sep 2015 06:24:04 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 62912 invoked by uid 99); 18 Sep 2015 06:24:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Sep 2015 06:24:04 +0000 Date: Fri, 18 Sep 2015 06:24:04 +0000 (UTC) From: "Zhe Zhang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8550) Erasure Coding: Fix FindBugs Multithreaded correctness Warning MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14805049#comment-14805049 ] Zhe Zhang commented on HDFS-8550: --------------------------------- Good point. I agree. > Erasure Coding: Fix FindBugs Multithreaded correctness Warning > -------------------------------------------------------------- > > Key: HDFS-8550 > URL: https://issues.apache.org/jira/browse/HDFS-8550 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Rakesh R > Assignee: Rakesh R > Attachments: HDFS-8550-HDFS-7285-00.patch, HDFS-8550-HDFS-7285-01.patch > > > Please find the findbug warnings [report|https://builds.apache.org/job/PreCommit-HDFS-Build/12444/artifact/patchprocess/patchFindbugsWarningshadoop-hdfs.html] > 1) {code} > Bug type IS2_INCONSISTENT_SYNC (click for details) > In class org.apache.hadoop.hdfs.DFSStripedInputStream > Field org.apache.hadoop.hdfs.DFSStripedInputStream.curStripeBuf > Synchronized 90% of the time > Unsynchronized access at DFSStripedInputStream.java:[line 829] > Synchronized access at DFSStripedInputStream.java:[line 183] > Synchronized access at DFSStripedInputStream.java:[line 186] > Synchronized access at DFSStripedInputStream.java:[line 184] > Synchronized access at DFSStripedInputStream.java:[line 382] > Synchronized access at DFSStripedInputStream.java:[line 460] > Synchronized access at DFSStripedInputStream.java:[line 461] > Synchronized access at DFSStripedInputStream.java:[line 461] > Synchronized access at DFSStripedInputStream.java:[line 285] > Synchronized access at DFSStripedInputStream.java:[line 297] > Synchronized access at DFSStripedInputStream.java:[line 298] > {code} > 2) > {code} > Unread field: org.apache.hadoop.hdfs.DFSStripedInputStream$BlockReaderInfo.targetBlock > Bug type URF_UNREAD_FIELD (click for details) > In class org.apache.hadoop.hdfs.DFSStripedInputStream$BlockReaderInfo > Field org.apache.hadoop.hdfs.DFSStripedInputStream$BlockReaderInfo.targetBlock > At DFSStripedInputStream.java:[line 126] > {code} > 3) > {code} > Unchecked/unconfirmed cast from org.apache.hadoop.hdfs.protocol.LocatedBlock to org.apache.hadoop.hdfs.protocol.LocatedStripedBlock in org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.setBlockToken(LocatedBlock, BlockTokenIdentifier$AccessMode) > Bug type BC_UNCONFIRMED_CAST (click for details) > In class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager > In method org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.setBlockToken(LocatedBlock, BlockTokenIdentifier$AccessMode) > Actual type org.apache.hadoop.hdfs.protocol.LocatedBlock > Expected org.apache.hadoop.hdfs.protocol.LocatedStripedBlock > Value loaded from b > At BlockManager.java:[line 974] > {code} > 4) > {code} > Result of integer multiplication cast to long in org.apache.hadoop.hdfs.util.StripedBlockUtil.divideOneStripe(ErasureCodingPolicy, int, LocatedStripedBlock, long, long, ByteBuffer) > Bug type ICAST_INTEGER_MULTIPLY_CAST_TO_LONG (click for details) > In class org.apache.hadoop.hdfs.util.StripedBlockUtil > In method org.apache.hadoop.hdfs.util.StripedBlockUtil.divideOneStripe(ErasureCodingPolicy, int, LocatedStripedBlock, long, long, ByteBuffer) > At StripedBlockUtil.java:[line 375] > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)