Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5EE9318EE4 for ; Wed, 30 Sep 2015 17:49:02 +0000 (UTC) Received: (qmail 91370 invoked by uid 500); 30 Sep 2015 17:48:49 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 91316 invoked by uid 500); 30 Sep 2015 17:48:49 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 91241 invoked by uid 99); 30 Sep 2015 17:48:49 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Sep 2015 17:48:49 +0000 Date: Wed, 30 Sep 2015 17:48:49 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8461) Erasure coding: fix priority level of UnderReplicatedBlocks for striped block MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938055#comment-14938055 ] Hudson commented on HDFS-8461: ------------------------------ FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #439 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/439/]) HDFS-8461. Erasure coding: fix priority level of UnderReplicatedBlocks (jing9: rev 2c494a843699b478039f41336cf47bd4c635eb76) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/UnderReplicatedBlocks.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestUnderReplicatedBlockQueues.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestRecoverStripedBlocks.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt > Erasure coding: fix priority level of UnderReplicatedBlocks for striped block > ----------------------------------------------------------------------------- > > Key: HDFS-8461 > URL: https://issues.apache.org/jira/browse/HDFS-8461 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Walter Su > Assignee: Walter Su > Fix For: HDFS-7285 > > Attachments: HDFS-8461-HDFS-7285.001.patch, HDFS-8461-HDFS-7285.002.patch > > > Issues 1: correctly mark corrupted blocks. > Issues 2: distinguish highest risk priority and normal risk priority. > {code:title=UnderReplicatedBlocks.java} > private int getPriority(int curReplicas, > ... > } else if (curReplicas == 1) { > //only on replica -risk of loss > // highest priority > return QUEUE_HIGHEST_PRIORITY; > ... > {code} > For stripe blocks, we should return QUEUE_HIGHEST_PRIORITY when curReplicas == 6( Suppose 6+3 schema). > That's important. Because > {code:title=BlockManager.java} > DatanodeDescriptor[] chooseSourceDatanodes(BlockInfo block, > ... > if(priority != UnderReplicatedBlocks.QUEUE_HIGHEST_PRIORITY > && !node.isDecommissionInProgress() > && node.getNumberOfBlocksToBeReplicated() >= maxReplicationStreams) > { > continue; // already reached replication limit > } > ... > {code} > It may return not enough source DNs ( maybe 5), and failed to recover. > A busy node should not be skiped if a block has highest risk/priority. The issue is the striped block doesn't have priority. -- This message was sent by Atlassian JIRA (v6.3.4#6332)