Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2CF4618EFB for ; Wed, 30 Sep 2015 17:49:20 +0000 (UTC) Received: (qmail 98812 invoked by uid 500); 30 Sep 2015 17:48:58 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 98752 invoked by uid 500); 30 Sep 2015 17:48:58 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 98673 invoked by uid 99); 30 Sep 2015 17:48:58 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Sep 2015 17:48:58 +0000 Date: Wed, 30 Sep 2015 17:48:58 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8428) Erasure Coding: Fix the NullPointerException when deleting file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938072#comment-14938072 ] Hudson commented on HDFS-8428: ------------------------------ FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #439 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/439/]) HDFS-8428. Erasure Coding: Fix the NullPointerException when deleting (zhezhang: rev 47ef869fa790dd096b576697c4245d2f3a3193fa) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt > Erasure Coding: Fix the NullPointerException when deleting file > --------------------------------------------------------------- > > Key: HDFS-8428 > URL: https://issues.apache.org/jira/browse/HDFS-8428 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Yi Liu > Assignee: Yi Liu > Fix For: HDFS-7285 > > Attachments: HDFS-8428-HDFS-7285.001.patch > > > In HDFS, when removing some file, NN will also remove all its blocks from {{BlocksMap}}, and send {{DNA_INVALIDATE}} (invalidate blocks) commands to datanodes. After datanodes successfully delete the block replicas, will report {{DELETED_BLOCK}} to NameNode. > snippet code logic in {{BlockManager#processIncrementalBlockReport}} is as following > {code} > case DELETED_BLOCK: > removeStoredBlock(storageInfo, getStoredBlock(rdbi.getBlock()), node); > ... > {code} > {code} > private void removeStoredBlock(DatanodeStorageInfo storageInfo, Block block, > DatanodeDescriptor node) { > if (shouldPostponeBlocksFromFuture && > namesystem.isGenStampInFuture(block)) { > queueReportedBlock(storageInfo, block, null, > QUEUE_REASON_FUTURE_GENSTAMP); > return; > } > removeStoredBlock(getStoredBlock(block), node); > } > {code} > In EC branch, we add {{getStoredBlock}}. There is {{NullPointerException}} when handling {{DELETED_BLOCK}} of incrementalBlockReport from DataNode after delete a file, since the block is already removed, we need to check. -- This message was sent by Atlassian JIRA (v6.3.4#6332)