Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CFC2A18A7F for ; Wed, 30 Sep 2015 16:38:25 +0000 (UTC) Received: (qmail 97099 invoked by uid 500); 30 Sep 2015 16:38:21 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 97045 invoked by uid 500); 30 Sep 2015 16:38:21 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 96970 invoked by uid 99); 30 Sep 2015 16:38:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Sep 2015 16:38:21 +0000 Date: Wed, 30 Sep 2015 16:38:21 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8378) Erasure Coding: Few improvements for the erasure coding worker MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14937512#comment-14937512 ] Hudson commented on HDFS-8378: ------------------------------ FAILURE: Integrated in Hadoop-Yarn-trunk #1203 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1203/]) HDFS-8378. Erasure Coding: Few improvements for the erasure coding (zhezhang: rev 914580934c566cd18019035b244f82006868bd7b) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java > Erasure Coding: Few improvements for the erasure coding worker > -------------------------------------------------------------- > > Key: HDFS-8378 > URL: https://issues.apache.org/jira/browse/HDFS-8378 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Rakesh R > Assignee: Rakesh R > Priority: Minor > Fix For: HDFS-7285 > > Attachments: HDFS-8378-HDFS-7285.00.patch > > > # Following log is confusing, make it tidy. Its missing {{break;}} statement and causing this unwanted logs. > {code} > 2015-05-10 15:06:45,878 INFO datanode.DataNode (BPOfferService.java:processCommandFromActive(728)) - DatanodeCommand action: DNA_ERASURE_CODING_RECOVERY > 2015-05-10 15:06:45,879 WARN datanode.DataNode (BPOfferService.java:processCommandFromActive(732)) - Unknown DatanodeCommand action: 11 > {code} > # Add exception trace to the log, would improve debuggability > {code} > } catch (Throwable e) { > LOG.warn("Failed to recover striped block: " + blockGroup); > } > {code} > # Make member variables present in ErasureCodingWorker, ReconstructAndTransferBlock, StripedReader {{private}} {{final}} > # Correct spelling of the variable {{STRIPED_READ_TRHEAD_POOL}} to {{STRIPED_READ_THREAD_POOL}} > # Good to add debug logs to print the striped read pool size > {code} > LOG.debug("Using striped reads; pool threads=" + num); > {code} > # Add meaningful message to the precondition check: > {code} > Preconditions.checkArgument(liveIndices.length == sources.length); > {code} > # Remove unused import > {code} > import org.apache.hadoop.hdfs.server.common.HdfsServerConstants; > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)