Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9FC3F187D3 for ; Wed, 30 Sep 2015 02:18:05 +0000 (UTC) Received: (qmail 75053 invoked by uid 500); 30 Sep 2015 02:18:05 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 75000 invoked by uid 500); 30 Sep 2015 02:18:05 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 74988 invoked by uid 99); 30 Sep 2015 02:18:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Sep 2015 02:18:05 +0000 Date: Wed, 30 Sep 2015 02:18:05 +0000 (UTC) From: "Wei-Chiu Chuang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7533) Datanode sometimes does not shutdown on receiving upgrade shutdown command MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936261#comment-14936261 ] Wei-Chiu Chuang commented on HDFS-7533: --------------------------------------- Hi [~kihwal] [~eepayne] , thanks for the effort fixing this issue. I just started Hadoop development recently and I am reviewing this issue. It looks to me that catching Throwable and ignore it may cause other issues, for example, ignoring a OOME can be pretty bad. How able adding a warning message after catching Throwable? It would be great if you could elaborate on this. Thank you > Datanode sometimes does not shutdown on receiving upgrade shutdown command > -------------------------------------------------------------------------- > > Key: HDFS-7533 > URL: https://issues.apache.org/jira/browse/HDFS-7533 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Kihwal Lee > Assignee: Eric Payne > Labels: 2.6.1-candidate > Fix For: 2.7.0, 2.6.1 > > Attachments: HDFS-7533-branch-2.6-v1.patch, HDFS-7533.v1.txt > > > When datanode is told to shutdown via the dfsadmin command during rolling upgrade, it may not shutdown. This is because not all writers have responder running, but sendOOB() tries anyway. This causes NPE and the shutdown thread dies, halting the shutdown after only shutting down DataXceiverServer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)