hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9148) Incorrect assert message in TestWriteToReplica#testWriteToTemporary
Date Sat, 26 Sep 2015 01:58:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908993#comment-14908993
] 

Daniel Templeton commented on HDFS-9148:
----------------------------------------

Looks good.  Thanks, [~twu].  Just add some parentheses after "createTemporary", i.e. createTemporary(),
and you have my +1.

> Incorrect assert message in TestWriteToReplica#testWriteToTemporary
> -------------------------------------------------------------------
>
>                 Key: HDFS-9148
>                 URL: https://issues.apache.org/jira/browse/HDFS-9148
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.7.1
>            Reporter: Tony Wu
>            Assignee: Tony Wu
>            Priority: Trivial
>         Attachments: hdfs-9148.patch
>
>
> The following assert text in TestWriteToReplica#testWriteToTemporary is not correct:
> {code:java}
>       Assert.fail("createRbw() Should have removed the block with the older "
>           + "genstamp and replaced it with the newer one: " + blocks[NON_EXISTENT]);
> {code}
> If the assert is triggered, it can only be due to an temporary replica already exists
and has newer generation stamp. It should have nothing to do with createRbw().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message