hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9111) Move hdfs-client protobuf convert methods from PBHelper to PBHelperClient
Date Sun, 20 Sep 2015 00:42:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877357#comment-14877357
] 

Mingliang Liu commented on HDFS-9111:
-------------------------------------

The two failing tests are because of {{TimeoutException}}. They fail in other recent builds,
eg [HDFS-9106 | https://issues.apache.org/jira/browse/HDFS-9106?focusedCommentId=14876509&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14876509].
They can pass locally.

As this jira focuses on the code move, we'll address the existing checkstyle warnings in [HDFS-8979].


> Move hdfs-client protobuf convert methods from PBHelper to PBHelperClient
> -------------------------------------------------------------------------
>
>                 Key: HDFS-9111
>                 URL: https://issues.apache.org/jira/browse/HDFS-9111
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HDFS-9111.000.patch, HDFS-9111.001.patch
>
>
> *TL;DR* This jira tracks the effort of moving PB helper methods, which convert client
side data structure to and from protobuf, to the {{hadoop-hdfs-client}} module.
> Currently the {{PBHelper}} class contains helper methods converting both client and server
side data structures from/to protobuf. As we move client (and common) classes to {{hadoop-hdfs-client}}
module (see [HDFS-8053] and [HDFS-9039]), we also need to move client module related PB converters
to client module.
> A good place may be a new class named {{PBHelperClient}}. After this, the existing {{PBHelper}}
class stays in {{hadoop-hdfs}} module with converters for converting server side data structures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message