hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9111) Move hdfs-client protobuf convert methods from PBHelper to PBHelperClient
Date Sat, 19 Sep 2015 21:40:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877327#comment-14877327
] 

Hadoop QA commented on HDFS-9111:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  23m 11s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new
or modified test files. |
| {color:green}+1{color} | javac |   9m 22s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  11m 44s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 28s | The applied patch does not increase
the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   2m 57s | The applied patch generated  160 new checkstyle
issues (total was 40, now 200). |
| {color:green}+1{color} | whitespace |   4m 54s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 59s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 49s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   5m 46s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | native |   4m  9s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests |  75m  7s | Tests failed in hadoop-hdfs. |
| {color:green}+1{color} | hdfs tests |   0m 31s | Tests passed in hadoop-hdfs-client. |
| | | 141m  8s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.blockmanagement.TestNodeCount |
| Timed out tests | org.apache.hadoop.hdfs.TestListFilesInDFS |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12761302/HDFS-9111.001.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / c39ddc3 |
| checkstyle |  https://builds.apache.org/job/PreCommit-HDFS-Build/12558/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12558/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| hadoop-hdfs-client test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12558/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12558/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12558/console |


This message was automatically generated.

> Move hdfs-client protobuf convert methods from PBHelper to PBHelperClient
> -------------------------------------------------------------------------
>
>                 Key: HDFS-9111
>                 URL: https://issues.apache.org/jira/browse/HDFS-9111
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HDFS-9111.000.patch, HDFS-9111.001.patch
>
>
> *TL;DR* This jira tracks the effort of moving PB helper methods, which convert client
side data structure to and from protobuf, to the {{hadoop-hdfs-client}} module.
> Currently the {{PBHelper}} class contains helper methods converting both client and server
side data structures from/to protobuf. As we move client (and common) classes to {{hadoop-hdfs-client}}
module (see [HDFS-8053] and [HDFS-9039]), we also need to move client module related PB converters
to client module.
> A good place may be a new class named {{PBHelperClient}}. After this, the existing {{PBHelper}}
class stays in {{hadoop-hdfs}} module with converters for converting server side data structures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message