hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9110) Improve upon HDFS-8480
Date Tue, 22 Sep 2015 22:10:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903544#comment-14903544
] 

Hadoop QA commented on HDFS-9110:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  18m  5s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   8m  5s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  10m 23s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 25s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m 23s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  1s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   2m 32s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | native |   3m 16s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 159m  9s | Tests failed in hadoop-hdfs. |
| | | 205m 27s | |
\\
\\
|| Reason || Tests ||
| Timed out tests | org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints |
|   | org.apache.hadoop.hdfs.server.namenode.TestEditLogJournalFailures |
|   | org.apache.hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes |
|   | org.apache.hadoop.hdfs.server.mover.TestStorageMover |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12761691/HDFS-9110.05.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / cc2b473 |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12606/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12606/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12606/console |


This message was automatically generated.

> Improve upon HDFS-8480
> ----------------------
>
>                 Key: HDFS-9110
>                 URL: https://issues.apache.org/jira/browse/HDFS-9110
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.7.0
>            Reporter: Charlie Helin
>            Assignee: Charlie Helin
>            Priority: Minor
>             Fix For: 2.7.0, 2.6.1
>
>         Attachments: HDFS-9110.00.patch, HDFS-9110.01.patch, HDFS-9110.02.patch, HDFS-9110.03.patch,
HDFS-9110.04.patch, HDFS-9110.05.patch
>
>
> This is a request to do some cosmetic improvements on top of HDFS-8480. There a couple
of File -> java.nio.file.Path conversions which is a little bit distracting. 
> The second aspect is more around efficiency, to be perfectly honest I'm not sure what
the number of files that may be processed. However as HDFS-8480 eludes to it appears that
this number could be significantly large. 
> The current implementation is basically a collect and process where all files first is
being examined; put into a collection and after that processed. HDFS-8480 could simply be
further enhanced by employing a single iteration without creating an intermediary collection
of filenames by using a FileWalker



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message