hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9080) update htrace version to 4.0
Date Fri, 18 Sep 2015 00:05:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804720#comment-14804720
] 

Colin Patrick McCabe commented on HDFS-9080:
--------------------------------------------

Thanks for the review.

bq. You want to add hostname+port to this name("FSClient").? ... at least as an annotation?

It's automatically added by HTrace, depending on the configuration of {{tracer.id}}.

bq. You change the names of the pb params but use old ids. Thats a no-no. Add the new params
with new ids or, why not just note that you are stuffing high and low into trace and span
from 4.0.0 out... and RPC stays the same.

Hmm, those names are never sent over the wire, just the positions and types.  But I guess
I can leave them as-is.

bq. Should TracerConfigurationManager do Sampler too? Or that can be another patch

It definitely should, but that would be a new feature :)  Right now you can only change {{SpanReceivers}}
via RPC, not {{Samplers}}.  That's definitely an oversight we should fix in another patch.

bq. Below import \[not\] needed in your doc.

Fixed

bq. Unused 32	import org.apache.htrace.core.Tracer; in ClientContext?

Fixed

bq. I can see why you have Tracer as static on FileSystem. What will happen in case where
two FileSystems in same JVM? Not important I suppose.... (there'll be no tracing in any setup
– unit test – that does such a thing). Thats fine.

It'll be OK.  The Tracer methods are thread-safe.

bq. I suppose this is correct... assuming that the parent at position zero is first parent....
Can it be null? (It throws exception in this case? A null parent down here would be an error?)

No, it can't be null.

> update htrace version to 4.0
> ----------------------------
>
>                 Key: HDFS-9080
>                 URL: https://issues.apache.org/jira/browse/HDFS-9080
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.8.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-9080.001.patch, HDFS-9080.002.patch, HDFS-9080.003.patch, HDFS-9080.004.patch
>
>
> Update the HTrace library version Hadoop uses to htrace 4.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message