hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9080) update htrace version to 4.0
Date Thu, 17 Sep 2015 23:03:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804679#comment-14804679
] 

stack commented on HDFS-9080:
-----------------------------

You want to add hostname+port to this            name("FSClient").?  ... at least as an annotation?

This is NOT catastrophic:

76	      LOG.info("Failed to add SpanReceiver " + info.getClassName() +

.... so INFO seems fine but what happens to the thrown exception? Is it going to be panic
stations in the tiers above?

You change the names of the pb params but use old ids. Thats a no-no. Add the new params with
new ids or, why not just note that you are stuffing high and low into trace and span from
4.0.0 out... and RPC stays the same.

64	  optional int64 parentIdHigh = 1;
65	  optional int64 parentIdLow = 2;

Above happens in two places.

Should TracerConfigurationManager do Sampler too? Or that can be another patch.

Below import needed in your doc.
    import org.apache.htrace.core.Sampler;

Spelling static final String SEHLL_HTRACE_PREFIX = "dfs.shell.htrace.";

Unused 32	import org.apache.htrace.core.Tracer; in ClientContext?

I like the old name over this one     TraceScope scope = newPathTraceScope("getBlockSize",
f);  : i.e. getPathT....   Same for newSrcDstTraceScope

I can see why you have Tracer as static on FileSystem. What will happen in case where two
FileSystems in same JVM? Not important I suppose.... (there'll be no tracing in any setup
--  unit test -- that does such a thing). Thats fine.

I suppose this is correct... assuming that the parent at position zero is first parent....
Can it be null? (It throws exception in this case?  A null parent down here would be an error?)

560	              scope = FileSystem.tracer.newScope("dataStreamer", parents[0]);
561	              scope.getSpan().setParents(parents);












> update htrace version to 4.0
> ----------------------------
>
>                 Key: HDFS-9080
>                 URL: https://issues.apache.org/jira/browse/HDFS-9080
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.8.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-9080.001.patch, HDFS-9080.002.patch, HDFS-9080.003.patch, HDFS-9080.004.patch
>
>
> Update the HTrace library version Hadoop uses to htrace 4.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message